Re: [Xen-devel] [PATCH 1/2] xen, libxc: init msix addr/data with value from qemu via hypercall

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.05.13 at 10:17, Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx> wrote:
> Accelerated msix entry is initialized to zero when msixtbl_pt_register is
> called. This doesn't match the value from qemu side, although pirq may 
> already
> be mapped and binded in qemu side. Kernel will get wrong value when reading
> msix info.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>
> Tested-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>

I appreciate this needing to change, but it is a no-go to expose an
implementation detail of the hypervisor (number of accelerated
entries being 3) trough a hypercall interface (and even less so by
scattering around literal 3-s).

Please work towards a different solution, leaving the tool stack
agnostic to the number of accelerated entries. And if at all
possible, arrange for the patch to be split into tool stack and
hypervisor pieces, such that they can be applied independently
(and in either order).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel