[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: unconst the event argument to the event_occurs hook. [and 1 more messages]



On Wed, 2013-05-01 at 11:48 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] libxl: unconst the event argument to the 
> event_occurs hook."):
> > The event is supposed to become owned, and therefore freed, by the 
> > application
> > and the const prevents this.
> > 
> > Unfortunately there is no way to remove the const without breaking existing
> > callers. The best we can do is use the LIBXL_API_VERSION provisions to 
> > remove
> > the const for callers who wish only to support the 4.3 API and newer.
> > 
> > Callers who wish to support 4.2 will need to live with casting away the 
> > const.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Ian.Jackson@xxxxxxxxxx
> > Cc: George.Dunlap@xxxxxxxxx
> > Cc: Jim Fehlig <jfehlig@xxxxxxxx>
> > Cc: Rob Hoes <Rob.Hoes@xxxxxxxxxx>
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Applied with this + Jim's previous R-b, thanks both.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.