Re: [Xen-devel] [RFC 29/29] xen/arm64: Remove hardcoded value for gic in assembly code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-29 at 00:02 +0100, Julien Grall wrote:
> - arm64: use V2M_GIC_BASE_ADDRESS
> - only expose GIC_*_ADDRESS to assembly. The C code uses base addresses
> provide by the device tree
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
> index 943175f..eb13bf4 100644
> --- a/xen/include/asm-arm/config.h
> +++ b/xen/include/asm-arm/config.h
> @@ -141,12 +141,16 @@ extern unsigned long frametable_virt_end;
>  #define watchdog_disable() ((void)0)
>  #define watchdog_enable()  ((void)0)
>  
> -/* Board-specific: base address of GIC + its regs */
> -#define GIC_BASE_ADDRESS 0x2c000000
> +#ifdef __ASSEMBLY__

This is a good idea!

> +/* Board-specific: regs base address for the GIC
> + * Theses constants are only intend to be used in assembly file
> + * because the DT is not yet parsed.t diff

Stray gi"t diff" here ;-)

> + */
>  #define GIC_DR_OFFSET 0x1000
>  #define GIC_CR_OFFSET 0x2000
>  #define GIC_HR_OFFSET 0x4000 /* Guess work 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2011-September/064219.html
>  */
>  #define GIC_VR_OFFSET 0x6000 /* Virtual Machine CPU interface) */
> +#endif /* __ASSEMBLY__ */
>  
>  #endif /* __ARM_CONFIG_H__ */
>  /*



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel