[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 06/29] xen/arm: Load dtb after dom0 kernel



On Mon, 2013-04-29 at 00:01 +0100, Julien Grall wrote:
> On some setup, the first linux page table is at 0x40004000. Xen will load
> dom0 device tree at 0x4000100. In case of the device tree is big, linux will
> corrupt the device tree.

How big can a dtb be? To clash it'd need to be 15ÂK?

> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>


I suppose right after the kernel is as good as anywhere:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  xen/arch/arm/domain_build.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 3f50193..ad0ab35 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -407,8 +407,9 @@ int construct_dom0(struct domain *d)
>      /* The following loads use the domain's p2m */
>      p2m_load_VTTBR(d);
>  
> -    dtb_load(&kinfo);
> +    kinfo.dtb_paddr = kinfo.zimage.load_addr + kinfo.zimage.len;
>      kernel_load(&kinfo);
> +    dtb_load(&kinfo);
>  
>      discard_initial_modules();
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.