Re: [Xen-devel] [RFC 04/29] xen/arm: Bump early printk internal buffer to 512

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-29 at 00:01 +0100, Julien Grall wrote:
> When debug is enabled in device tree code, some lines
> are bigger than 80 characters.

I'm a little concerned about putting such a relatively large thing on
the stack. Especially the initstack which I have a feeling is only 4K.

We are single processor when early_printk is used, right? So a static
__initdata buffer would also work?

> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> ---
>  xen/arch/arm/early_printk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/early_printk.c b/xen/arch/arm/early_printk.c
> index bdf4c0e..b21f572 100644
> --- a/xen/arch/arm/early_printk.c
> +++ b/xen/arch/arm/early_printk.c
> @@ -41,7 +41,7 @@ static void __init early_puts(const char *s)
>  
>  static void __init early_vprintk(const char *fmt, va_list args)
>  {
> -    char buf[80];
> +    char buf[512];
>  
>      vsnprintf(buf, sizeof(buf), fmt, args);
>      early_puts(buf);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel