Re: [Xen-devel] [PATCH 1/2] Xen/vMCE: bugfix of vmce injection

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.04.13 at 10:37, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> From 061ec508b405f84e2f70c80b02de63061c49648d Mon Sep 17 00:00:00 2001
> From: Liu Jinsong <jinsong.liu@xxxxxxxxx>
> Date: Sat, 27 Apr 2013 21:46:35 +0800
> Subject: [PATCH 1/2] Xen/vMCE: bugfix of vmce injection
> 
> Fix vmce injection bug rooted from uint_16 to int parameter,
> resulting in dom0 crash when inject vmce to dom0:

The patch is fine, but the description requires one to actually go
look at the code to understand what the problem is - you should
have mentioned the bad interaction between uint16_t and
VMCE_INJECT_BROADCAST.

Jan

> (XEN) inject vMCE to DOM0 failed
> (XEN) domain_crash called from mcaction.c:133
> (XEN) Domain 0 reported crashed by domain 32767 on cpu#21:
> (XEN) Domain 0 crashed: rebooting machine in 5 seconds.
> (XEN) Resetting with ACPI MEMORY or I/O RESET_REG.
> 
> Signed-off-by: Liu Jinsong <jinsong.liu@xxxxxxxxx>
> ---
>  xen/arch/x86/cpu/mcheck/mcaction.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/xen/arch/x86/cpu/mcheck/mcaction.c 
> b/xen/arch/x86/cpu/mcheck/mcaction.c
> index 5627192..0ac5b45 100644
> --- a/xen/arch/x86/cpu/mcheck/mcaction.c
> +++ b/xen/arch/x86/cpu/mcheck/mcaction.c
> @@ -45,7 +45,7 @@ mc_memerr_dhandler(struct mca_binfo *binfo,
>      struct domain *d;
>      unsigned long mfn, gfn;
>      uint32_t status;
> -    uint16_t vmce_vcpuid;
> +    int vmce_vcpuid;
>  
>      if (!mc_check_addr(bank->mc_status, bank->mc_misc, MC_ADDR_PHYSICAL)) {
>          dprintk(XENLOG_WARNING,
> -- 
> 1.7.1




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel