[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] FIX: Cast the time_t values to avoid warnings


  • To: xen-devel@xxxxxxxxxxxxx
  • From: 7heo@xxxxxxx
  • Date: Sat, 27 Apr 2013 23:32:35 +0200
  • Delivery-date: Sat, 27 Apr 2013 21:33:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On Sat, Apr 27, 2013 at 09:18:03PM +0100, Patrick Welche wrote:
> On Sat, Apr 27, 2013 at 09:52:33PM +0200, 7heo wrote:
> > I added 4 casts from time_t to unsigned long int
> > in the libxl_sprintf functions, so there is no
> > warning at compilation time (and no failing with
> > -Werror).
> > 
> > The casting format has been discuted, and since
> > there is no system having a 8 byte time_t format
> > yet; unsigned long int should be sufficient.
> > Also, it matches the libxl_sprintf syntax (%lu).
> 
> I thought that earlier in the thread someone pointed
> out that unsigned long long would be a better plan?
> (long could just be 32 bits long)
> 
> Cheers,
> 
> Patrick

As explained in the second paragraph of the git commit
message (even if I did a typo); this has been discussed
already.

Regards,
7heo.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.