Re: [Xen-devel] [PATCH] xen/arm: Fix return value when write is ignored in VGIC

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-04-26 at 14:16 +0100, Julien Grall wrote:
> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> If a write is ignored, the function should return success.
> 
> Currently Xen will throw a data abort exception if the write in VGIC is
> ignored.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  xen/arch/arm/vgic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index 6cceb0f..6aaafe9 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -592,7 +592,7 @@ bad_width:
>  
>  write_ignore:
>      if ( dabt.size != 2 ) goto bad_width;
> -    return 0;
> +    return 1;
>  }
>  
>  static int vgic_distr_mmio_check(struct vcpu *v, paddr_t addr)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel