Re: [Xen-devel] default timer_mode in xen and in libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-04-25 at 18:13 +0100, Stefano Stabellini wrote:
> Hi all,
> I have just noticed that the timer mode default in libxl is not the
> default in Xen.
> The Xen default is HVMPTM_delay_for_missed_ticks, while libxl by
> default sets it to LIBXL_TIMER_MODE_NO_DELAY_FOR_MISSED_TICKS that
> obviously is HVMPTM_no_delay_for_missed_ticks.
> 
> Is there a reason for this?
> If so, should we change the defalt in Xen too?
> 
> commit 2d058a444a1fa71ec47a673d08c2e74790ae67fb
> Author: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Date:   Thu Mar 1 12:26:13 2012 +0000
> 
>     libxl: use an explicit LIBXL_TIMER_MODE_DEFAULT value
>     
>     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

This commit just changed the way the default was set, but it didn't
change that default. Tracking back through the history it seems the
original change was:

        commit 85bd32d9085828dcfa29215c78d472afa0cfd3ad
        Author: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
        Date:   Wed Jul 14 16:31:59 2010 +0100
        
            xl: default timer_mode to 1
            
            Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
        
        diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
        index e7aa89b..9706a6a 100644
        --- a/tools/libxl/xl_cmdimpl.c
        +++ b/tools/libxl/xl_cmdimpl.c
        @@ -205,7 +205,7 @@ static void init_build_info(libxl_domain_build_info 
*b_info, libxl_domain_create
                 b_info->u.hvm.viridian = 0;
                 b_info->u.hvm.hpet = 1;
                 b_info->u.hvm.vpt_align = 1;
        -        b_info->u.hvm.timer_mode = 0;
        +        b_info->u.hvm.timer_mode = 1;
             } else {
                 b_info->u.pv.slack_memkb = 8 * 1024;
             }
        
So you tell us ;-) (you see now why I'm picky about changelogs...)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel