Re: [Xen-devel] [PATCH v3 03/13] xen: introduce cpumask_from_bitmap

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-04-25 at 16:13 +0100, Keir Fraser wrote:
> On 25/04/2013 15:51, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Thu, 2013-04-25 at 15:44 +0100, Ian Campbell wrote:
> >> On Thu, 2013-04-25 at 15:42 +0100, Ian Campbell wrote:
> >>> And it really wants to act on sets of real physical cpus (hence 
> >>> cpumask_t)?
> >> 
> >> Actually, vcpus. Perhaps cpumask_t is the wrong datatype then?
> > 
> > x86 defines for_each_set_bit in terms of find_first_bit and
> > find_next_bit (both of which we have on ARM). Seems like we should just
> > carry that over?
> 
> Yup, seems a shame to duplicate it into asm-arm, but I can live with it. I
> can imagine some arch wanting a specialised version of it sometime.

We could move it to generic code, perhaps with a containing ifndef for
this next arch...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel