Re: [Xen-devel] [PATCH v3 10/13] xen/arm: support VCPUOP_register_vcpu_info.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-04-25 at 15:29 +0100, Keir Fraser wrote:
> On 25/04/2013 12:38, "Stefano Stabellini" <stefano.stabellini@xxxxxxxxxxxxx>
> wrote:
> 
> >>> +long do_restricted_vcpu_op(int cmd, int vcpuid,
> >>> XEN_GUEST_HANDLE_PARAM(void) arg)
> >> 
> >> This is a bit fugly but I suppose it's no worse than the other
> >> alternatives I can think of.
> >> 
> >> I don't really like the "restricted" name but the other obvious
> >> alternative do_arch_vcpu_op is out because typically that's called
> >> *from* do_foo_op not instead of.
> >> 
> >> Is renaming do_vcpu_op to do_common_vcpu_op and adding do_vcpu_op as
> >> per-arch on all architectures (basically a nop on x86) an option?
> > 
> > This is a question for the x86 maintainers.
> 
> Why not just call it do_arm_vcpu_op() or something? I.e., a new naming
> convention that indicates this arch-specific fn wraps the common hypercall
> fn?

That is a very sane idea!

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel