[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] hotplug/Linux: add iscsi block hotplug script

> >>>
> >>>> +        echo "Unable to find iscsiadm tool"
> >>>> +        return 1
> >>>
> >>> Error paths should use fatal() from xen-hotplug-common.sh so the error
> >>> is propagated to xenstore and libxl can print it.
> >>
> >> Yes, if we call the script directly from libxl the output form the
> >> script will be logged by libxl,
> > 
> > Actually logged or just sent to stdout which libxl hasn't interfered
> > with? or does libxl suck in the stdout of the script? It looks to me
> > like libxl does the former.
> > 
> >> but since this script can also be called from udev I have to use fatal.
> > 
> > I think even for libxl, since it writes the error node which libxl does
> > then log.
> Yes, libxl checks the node, so it's better to use fatal/log and all this
> functions instead of printing to stdout/stderr.


Slurping hotplug script output into a debug log file might actually be a
useful thing for the TODO list though.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.