Re: [Xen-devel] [PATCH 12/17] PVH xen: support invalid op, return PVH features etc...

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Wed, 24 Apr 2013 10:01:26 +0100
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 23.04.13 at 23:26, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> > --- a/xen/arch/x86/debug.c
> > +++ b/xen/arch/x86/debug.c
> > @@ -59,7 +59,9 @@ dbg_hvm_va2mfn(dbgva_t vaddr, struct domain *dp,
> > int toaddr, return INVALID_MFN;
> >      }
> >  
> > -    mfn = mfn_x(get_gfn(dp, *gfn, &gfntype)); 
> > +    mfn = mfn_x(get_gfn_query(dp, *gfn, &gfntype));
> > +    put_gfn(dp, *gfn);
> > +
> >      if ( p2m_is_readonly(gfntype) && toaddr )
> >      {
> >          DBGP2("kdb:p2m_is_readonly: gfntype:%x\n", gfntype);
> > @@ -178,9 +180,6 @@ dbg_rw_guest_mem(dbgva_t addr, dbgbyte_t *buf,
> > int len, struct domain *dp, }
> >  
> >          unmap_domain_page(va);
> > -        if ( gfn != INVALID_GFN )
> > -            put_gfn(dp, gfn);
> > -
> >          addr += pagecnt;
> >          buf += pagecnt;
> >          len -= pagecnt;
> 
> How is this change related to PVH? I.e. isn't this a standalone fix/
> change?
> 
> Jan

fine. I'll move it to a separate patch.

thanks,
Mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel