Re: [Xen-devel] [PATCH] xenstore: create pidfile in init-xenstore-domain

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-22 at 18:06 +0100, Daniel De Graaf wrote:

> @@ -90,5 +91,12 @@ int main(int argc, char** argv)
>       xs_write(xsh, XBT_NULL, "/tool/xenstored/domid", buf, rv);
>       xs_daemon_close(xsh);
>  
> +     fd = creat("/var/run/xenstored.pid", 0666);

This is world writeable which doesn't seem like a good idea.

Most of the pidfiles on my system seem to use 0644.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel