Re: [Xen-devel] [PATCH V2] hotplug: add openvswitch script

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-22 at 18:20 +0100, Roger Pau Monne wrote:
> On 22/04/13 19:05, Ian Campbell wrote:
> > On Mon, 2013-04-22 at 17:46 +0100, Roger Pau Monne wrote:
> >>> +    offline)
> >>
> >> Don't you need a "remove" here?
> >>
> >> remove|offline)
> >>    ...
> >>
> >> Or it doesn't matter because when the tap device is destroyed everything
> >> is automagically cleaned?
> > 
> > Even if that were the case I wouldn't want to rely on it, so we should
> > try and clean up explicitly.
> > 
> > Is this tap devices which only generates add/remove and not
> > online/offline? Do you happen to know the sequence of events for both
> > types of device?
> 
> It's all in libxl_linux.c, libxl__hotplug_nic in case you want to take a
> look at the implementation, the sequence of events for HVM guests should be:

Ah, yes, I'd forgotten I wasn't worrying about udev anymore.

Anyway, I confirmed that I was leaking the vifX.y-emu devices into the
OVS configuration, since unlike bridges OVS ports are persistent and not
tied to the existence of the actual device. With the change you
suggested things are fine. V3 on its way...

Thanks,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel