[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 1/2] xen: export do_block, add a parameter to enable local events delivery

On Fri, 19 Apr 2013, Jan Beulich wrote:
> >>> On 19.04.13 at 16:06, Stefano Stabellini 
> >>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > -static long do_block(void)
> > +int do_block(int event_delivery_enable)
> In the previous version you didn't need this new parameter, so
> what changed since then?

I changed the ARM implementation of local_event_delivery_enable: now it
clears PSR_IRQ_MASK (the interrupt flag). That is the correct behavior
for the implementation of the SCHEDOP_block hypercall but it is not the
right behavior for the WFI trap handler. In order to reuse this code, I
had to add the event_delivery_enable parameter.

> Also, please use bool_t for boolean parameters.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.