[Xen-devel] [PATCH 10 of 13 v5] blktap3/libblktapctl: Introduce tap-ctl-create

[Thanos Makatos <thanos.makatos@xxxxxxxxxx>]

Function tap_ctl_create spawns, attaches, and opens the tapdisk in one go
instead of having to call tap_ctl_spawn, tap_ctl_attach, and tap_ctl_open.

Signed-off-by: Thanos Makatos <thanos.makatos@xxxxxxxxxx>

---
Changed since v3:
  * Introduced patch in patch series.

Changed since v4:
  * Remove the minor number and replace it with type:/path/to/file.
  * Remove call to tap_ctl_detach in the error handling path.

diff --git a/tools/blktap3/control/tap-ctl-create.c 
b/tools/blktap3/control/tap-ctl-create.c
new file mode 100644
--- /dev/null
+++ b/tools/blktap3/control/tap-ctl-create.c
@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2008, XenSource Inc.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in the
+ *       documentation and/or other materials provided with the distribution.
+ *     * Neither the name of XenSource Inc. nor the names of its contributors
+ *       may be used to endorse or promote products derived from this software
+ *       without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
+ * OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+ * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <stdio.h>
+#include <errno.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <getopt.h>
+#include <string.h>
+
+#include "tap-ctl.h"
+#include "blktap3.h"
+
+int
+tap_ctl_create(const char *params, int flags, const char * prt_path,
+        char *secondary)
+{
+    int err, id;
+
+    id = tap_ctl_spawn();
+    if (id < 0) {
+        EPRINTF("error spawning tapdisk: %s", strerror(id));
+        return id;
+    }
+
+    err = tap_ctl_open(id, params, flags, prt_path, secondary);
+    if (err) {
+        EPRINTF("error opening tapdisk: %s", strerror(err));
+        /* FIXME must kill tapdisk */
+    }
+
+    return err;
+}

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel