[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 2/2] xl: Add commands for usb hot-plug

Roger Pau Monne writes ("Re: [PATCH v4 2/2] xl: Add commands for usb hot-plug"):
> On 11/04/13 20:51, George Dunlap wrote:
> > +#define is_dec(_c) ((_c) >= '0' && (_c) <= '9')
> > +#define is_hex(_c) (is_dec(_c) || ((_c) >= 'a' && (_c) <= 'f'))
> This are kind of general macros, that could be used elsewhere, might be
> suitable to put them outside of this function and name them CHAR_IS_DEC
> and CHAR_IS_HEX.

Also, while we're discussing this: the _'s at the start of the macro
formal parameter names are unnecessary, and not usual in libxl.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.