Re: [Xen-devel] [PATCH 5/8] kexec: extend hypercall with improved load/unload ops

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 09/04/13 22:02, Daniel Kiper wrote:
> On Mon, Apr 08, 2013 at 07:59:50PM +0100, David Vrabel wrote:
>> 
>> -static int kexec_load_unload_compat(unsigned long op,
>> -                                    XEN_GUEST_HANDLE_PARAM(void) uarg)
>> +static int kexec_load_v1_compat(XEN_GUEST_HANDLE_PARAM(void) uarg)
>>  {
>>  #ifdef CONFIG_COMPAT
>>      compat_kexec_load_v1_t compat_load;
>> @@ -808,49 +1011,113 @@ static int kexec_load_unload_compat(unsigned long op,
>>      load.type = compat_load.type;
>>      XLAT_kexec_image(&load.image, &compat_load.image);
>>
>> -    return kexec_load_unload_internal(op, &load);
>> -#else /* CONFIG_COMPAT */
>> +    return kexec_do_load_v1(&load, 1);
>> +#else
> 
> Why did you removed comment?

It's unhelpful clutter when the #if/#else/#endif are close together.

>>      return 0;
> 
> Why not -ENOSYS?

It's unreachable code so it doesn't matter.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel