Re: [Xen-devel] [PATCH 09/17] [V3]PVH xen: create PVH vmcs, and initialization

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.04.13 at 03:08, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> On Mon, 15 Apr 2013 16:47:49 +0100 "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> > @@ -4514,6 +4591,8 @@ static int hvm_memory_event_traps(long p,
>> > uint32_t reason, 
>> >  void hvm_memory_event_cr0(unsigned long value, unsigned long old) 
>> >  {
>> > +    if ( is_pvh_vcpu(current) )
>> > +        return;
>> 
>> This is temporary only, isn't it? If so, it should be clearly marked
>> as such.
> 
> I am not sure what these event calls are about, I guessed it was for
> some external debugger? 

No, these are for paging and/or page sharing afaik. And this is
functionality you definitely want for PVH guests (since it's only
the PV MMU interface that prevents PV guests from having this
enabled without a _lot_ of work).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel