Re: [Xen-devel] [PATCH v4 1/2] libxl: postpone backend name resolution

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-15 at 15:59 +0100, Ian Campbell wrote:
> > And make sure callers only call this function if there's a real need to
> > resolve a domid.
> 
> Did you mean !name && !domid? i.e. fail if no name is given AND domid
> isn't already set? But domid == 0 is a valid domid...

I think I missed the fact that domid is a pointer. In that case I
think !domid is an outright error in the caller (unless there is a
usecase for determining if a qualifier is valid?).

As I say though I think name == NULL is ok given the intended semantics.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel