Re: [Xen-devel] [PATCH v2] tools/ocaml: Fix library generation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-15 at 11:09 +0100, Vincent Bernardoff wrote:
> Fix the commands given to the OCaml compiler to make the OCaml
> bindings to Xen usable outside the build environment.
> 
> Signed-off-by: Vincent Bernardoff <vincent.bernardoff@xxxxxxxxxx>
> 
> ---
> Changed since v1:
>       * tools/Rules.mk is not modified, changes are now in
>           bottom-level Makefiles of OCaml libraries

How does this relate to the patch which Andy Cooper posted in
<fe2d14f39de68ab01ac2.1365012176@xxxxxxxxxxxxxxxxxxxxxxxxxxx> ?

> diff --git a/tools/ocaml/libs/eventchn/Makefile 
> b/tools/ocaml/libs/eventchn/Makefile
> index 2d8d618..ddd2ace 100644
> --- a/tools/ocaml/libs/eventchn/Makefile
> +++ b/tools/ocaml/libs/eventchn/Makefile
> @@ -8,7 +8,7 @@ OBJS = xeneventchn
>  INTF = $(foreach obj, $(OBJS),$(obj).cmi)
>  LIBS = xeneventchn.cma xeneventchn.cmxa
>  
> -LIBS_xeneventchn = $(LDLIBS_libxenctrl)
> +LIBS_xeneventchn = -L$(XEN_LIBXC) -lxenctrl

The problem with this is that it seems to reintroduce a form of the
problem solved by b7ee8d2f432f, that is accidental linking against
libraries in /usr/lib (or elsewhere) instead of the freshly built ones
in the source tree.

Andy's version of the patch seems to have solved that issue, I was just
hoping for a brief explanation of how (per
<1365607338.27868.87.camel@xxxxxxxxxxxxxxxxxxxxxx>) before I through it
in the tree.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel