[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] xen/xsm: add hooks for claim and debug port

>>> On 11.04.13 at 17:35, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> This replaces the IS_PRIV checks on these newly introduced operations
> with equivalent XSM hooks, and adds FLASK access vectors for them.

Doing this for the tmem ones obviously makes sense.

I wonder though what the point is of doing this for the debug port
one. When the hypervisor uses a debug port based console, it is
mandatory for the Dom0 kernel's EHCI driver to issues these calls
when resetting the controller (or else the console will stop working,
and Xen will hang at least temporarily). So having _any_ means to
deny this operation seems counterproductive to me.

Furthermore, an EHCI controller that the hypervisor runs its console
through can't be assigned to other than Dom0 (for that very reason),
so if you imply the option of a driver domain, then this aspect needs
to be worked out first, _before_ adding access control.

So first of all, please split the patch for the uncontroversial part to
go in.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.