Re: [Xen-devel] [PATCH] xen/arm: Save/Restore GICH_APR register

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-04-05 at 11:52 +0100, Stefano Stabellini wrote:
> On Thu, 4 Apr 2013, Julien Grall wrote:
> > Linux uses GICC_CTLR.EOImodeNS set to 0, which means both priority drop
> > and deactivate interrupt functionality are made when something is
> > written in GICC_EOIR.
> > 
> > As the ARM manual specifies: "having an active interrupt in the List 
> > registers
> > with a priority that is not set in the corresponding Active Priorities 
> > register"
> > when GICV_CTLR.EOImode (ie GICC_CTLR.EOImodeNS in the guest context) result
> > in unpredicable behavior, we need to save/restore GICH_APR.
> > 
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Nice catch!!

Indeed! I don't suppose you had a glance through the docs for other gic
registers we've missed?

> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

me too + Applied.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel