[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3 of 5 v4] tools/libxc: Implement xc_readconsolering_buffer()

On Wed, 2013-03-13 at 12:52 +0000, Andrew Cooper wrote:
> +/*
> + * For both readconsolering functions, *pnr_chars is both an input and
> + * output.  As an input, it specifies the size of *buffer, and as an output
> + * indicates now many character Xen wrote into *buffer.
> + *
> + * The 'clear' parameter indicates whether Xen should clear the buffer or 
> not.

Buffer here refers to Xen's internal ring, not the char *buffer argument
to this function, right? If so the wording (at least in the context) is
a bit confusing!

The actual code looks good to me.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.