Re: [Xen-devel] [PATCH] allow xendomains to work for xl list -l

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

M A Young writes ("[PATCH] allow xendomains to work for xl list -l"):
> I have discovered a few problems when using the 
> tools/hotplug/Linux/init.d/xendomains startup script if you use xl instead 
> of xm.
> >From xen 4.2 onwards xl list -l gives a JSON format output containing no 
> spaces or line feeds, but the xendomains script expects the older format 
> (of xl in xen 4.1 and xm) of one key-value pair per line.
> This patch adds a new line after each comma in the output of xl list -l 
> before processing it further, allows there to be not to be a space between 
> the key and value format used by xl list -l and accepts the "Xen saved 
> domain" as a valid header for a saved xen image if xl is being used.
...
> This patch inserts a line feed after each comma in the output from
> xl list -l, allows there not to be a space between "name" and "domid" keys
> and their value, and accepts the "Xen saved domain" value as a valid header
> for a saved xen image if xl is being used.

Roger, do you have an opinion about this ?  Without testing it myself,
I'm inclined to accept the patch.

This does illuminate the fact that the JSON output is not the most
convenient thing for a shell to deal with.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel