Re: [Xen-devel] [PATCH] Try to use git commit id if hg changeset is unavailable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.04.13 at 08:40, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 11/04/2013 00:32, "Marek Marczykowski" <marmarek@xxxxxxxxxxxxxxxxxxxxxx> 
> wrote:
> 
>> As Xen uses git as primary repository, get git commit id for
>> xen_changeset info.
>> 
>> Maybe hg code should be removed completely?
>> 
>> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> 
> I think we could just remove the hg code. Any other opinions?

No. But if we someone wants it to be retained, the git invocation
should precede the hg one in any case.

Jan

>> ---
>>  xen/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/xen/Makefile b/xen/Makefile
>> index 0fb3db7..9e4e6f3 100644
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -126,7 +126,7 @@ include/xen/compile.h: include/xen/compile.h.in .banner
>>    -e 's/@@version@@/$(XEN_VERSION)/g' \
>>    -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \
>>    -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \
>> -     -e 's!@@changeset@@!$(shell ((hg parents --template "{date|date}
>> {rev}:{node|short}" >/dev/null && hg parents --template "{date|date}
>> {rev}:{node|short}") || echo "unavailable") 2>/dev/null)!g' \
>> +     -e 's!@@changeset@@!$(shell ((hg parents --template "{date|date}
>> {rev}:{node|short}" >/dev/null && hg parents --template "{date|date}
>> {rev}:{node|short}") || git show -s --pretty="%ad %h" || echo "unavailable")
>> 2>/dev/null | tr -d '\n')!g' \
>>    < include/xen/compile.h.in > $@.new
>> @grep \" .banner >> $@.new
>> @grep -v \" .banner
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel