[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] xl: 'xl info' print outstanding claims if enabled (claim_mode=1 in xl.conf)

Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH 3/3] xl: 'xl info' print 
outstanding claims if enabled (claim_mode=1 in xl.conf)"):
> On Mon, Apr 08, 2013 at 05:41:07PM +0100, Ian Jackson wrote:
> > But you need to explain how the user can get the toolstack to set the
> > domain's claim to zero.
> I can certainly include that. It does that once the guest has been started
> (also the hypervisor sets it to zero as the pages get allocated for the 
> guest).

Maybe I'm confused.  I took

     The toolstack can also choose
     to set the domain's claim to zero

to mean that a user might reasonably instruct the toolstack to set the
claim to zero.

If there is no facility to do that then I'm not sure why you would
mention setting the claim to zero in the documentation.

> > > +    l = xc_domain_get_outstanding_pages(ctx->xch);
> > > +    if (l < 0) {
> > > +        LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_WARNING, l, 
> > > "xc_domain_get_outstanding_pages failed.");
> > 
> > This needs wrapping to 75 columns or so.
> OK. Do you prefer the "xc..." to be split up or on a seperate line?

Either will do.

> > Also, is there a way to find out which domain these claims belong to ?
> > I didn't see it in your previous patch.
> It is possible - the two patches that would have exported said
> information to xcinfo were dropped as I was unsure where to display
> this. As in I could alter 'xl list' or 'xl mem-list' to contain that
> information, but that would change the syntax of the printout. I
> don't know if that is OK?

I agree that adding stuff to those interfaces is a bit troublesome.
But maybe there could be an option to enable claim information ?

I guess by default the claimed-but-not-yet-taken memory should show up
as included in the domain's memory allocation ?  Since
taken+(claimed_but_not_taken) is a more stable value and one the user
can adjust.

> Or I can introduce a new command 'xl claim-list' ? That would give
> that information?

That would be fine too.  Whatever you think is best.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.