Re: [Xen-devel] [PATCH 7/8] x86/VPMU: Save/restore VPMU only when necessary

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 04/10/2013 04:57 AM, Dietmar Hahn wrote:
>   
>   struct vpmu_struct {
>       u32 flags;
> +    u32 last_pcpu;
>       u32 hw_lapic_lvtpc;
>       void *context;
>       struct arch_vpmu_ops *arch_vpmu_ops;
> @@ -73,6 +74,8 @@ struct vpmu_struct {
>   #define VPMU_PASSIVE_DOMAIN_ALLOCATED       0x8
>   #define VPMU_CPU_HAS_DS                     0x10 /* Has Debug Store */
>   #define VPMU_CPU_HAS_BTS                    0x20 /* Has Branch Trace Store */
> +#define VPMU_CONTEXT_SAVE                   0x40 /* Force context save */
> +#define VPMU_STOPPED                        0x80 /* Stop counters while VCPU 
> is not running */
> Would it be better to group the VPMU_ state and context flags together and move
> special cpu flags behind?
Yes, I should do this.

I'll wait for other comments and will resend the patches.

(And will add VPMU dump code for AMD, similar to what you did for Intel.)

Thanks.
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel