Re: [Xen-devel] [PATCH 7/7] xen-netback: don't disconnect frontend when seeing oversize packet

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Apr 09, 2013 at 12:34:42PM +0100, David Laight wrote:
> > +           if (!drop_err && txp->size > first->size) {
> > +                   if (net_ratelimit())
> > +                           netdev_dbg(vif->dev,
> > +                                      "Packet is bigger than frame.\n");
> 
> It must be worth printing txp->size and first->size here.
> Similarly for the other errors in the other patches.
> 

Sure.

> Probably difficult for some of these errors, but it is
> sometimes worth saving the last 'bad' item. So that with
> an appropriate tool (maybe hexdump of /dev/kmem) it is
> possible to look at the actual contents and thus determine
> the actual source of the error.
> 

I doubt that you can get much information by analysing txp, it is just
controll structure in ring, not the actual packet content. The packet is
still in DomU.


Wei.

>       David
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel