Re: [Xen-devel] Compilation error crossbuilding tools.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Sat, 6 Apr 2013, Sander Bogaert wrote:
> On compilation ( followed the wiki ) I get:
> ....
> arm-linux-gnueabihf-gcc  -O1 -fno-omit-frame-pointer -marm -g
> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
> -Wdeclaration-after-statement -Wno-unused-but-set-variable
> -Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF .block-qcow2.o.d
>  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls
>  -Werror -Wno-unused -I../lib
> -I/home/user/source/xen/xen-main/tools/blktap/drivers/../../../tools/libxc
> -I/home/user/source/xen/xen-main/tools/blktap/drivers/../../../tools/include
> -I/home/user/source/xen/xen-main/tools/blktap/drivers/../../../tools/xenstore
> -I/home/user/source/xen/xen-main/tools/blktap/drivers/../../../tools/include
> -D_GNU_SOURCE -DMEMSHR -I ../../memshr -pthread  -c -o block-qcow2.o
> block-qcow2.c
> block-qcow2.c: In function 'bdrv_pread':
> block-qcow2.c:238:4: error: format '%llx' expects argument of type
> 'long long unsigned int', but argument 5 has type '__off_t'
> [-Werror=format]
> cc1: all warnings being treated as errors
> make[5]: *** [block-qcow2.o] Error 1
> make[5]: Leaving directory 
> `/home/user/source/xen/xen-main/tools/blktap/drivers'
> make[4]: *** [subdir-install-drivers] Error 2
> make[4]: Leaving directory `/home/user/source/xen/xen-main/tools/blktap'
> make[3]: *** [subdirs-install] Error 2
> make[3]: Leaving directory `/home/user/source/xen/xen-main/tools/blktap'
> make[2]: *** [subdir-install-blktap] Error 2
> make[2]: Leaving directory `/home/user/source/xen/xen-main/tools'
> make[1]: *** [subdirs-install] Error 2
> make[1]: Leaving directory `/home/user/source/xen/xen-main/tools'
> make: *** [install-tools] Error 2

Reading the error, I think that the appended patch (completely untested)
should fix the problem:

diff --git a/tools/blktap/drivers/block-qcow2.c 
b/tools/blktap/drivers/block-qcow2.c
index ceda4f0..903d065 100644
--- a/tools/blktap/drivers/block-qcow2.c
+++ b/tools/blktap/drivers/block-qcow2.c
@@ -30,6 +30,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <sys/mman.h>
 #include <sys/stat.h>
 
 #include "tapdisk.h"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel