Re: [Xen-devel] [PATCH 3/3 v2] vpmu intel: Dump vpmu infos in 'q' keyhandler

[Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>]

Am Freitag 05 April 2013, 16:30:13 schrieb Jan Beulich:
> >>> On 05.04.13 at 15:33, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 
> >>> wrote:
> > On Thu, Apr 04, 2013 at 02:10:32PM +0200, Dietmar Hahn wrote:
> >> Am Donnerstag 28 MÃrz 2013, 14:01:10 schrieb Dietmar Hahn:
> >> > @@ -132,6 +132,16 @@ static const u32 core2_fix_counters_msr[
> >> >      MSR_CORE_PERF_FIXED_CTR2
> >> >  };
> >> >  
> >> > +/*
> >> > + * MSR_CORE_PERF_FIXED_CTR_CTRL contains the configuration of all fixed
> >> > + * counters. 4 bits for every counter.
> >> > + */
> >> > +#define FIXED_CTR_CTRL_BITS 4
> > 
> > That is a lot of 'CTR' in it. Can it be just one CTRL ?
> > 
> > Say FIXED_CTRL_BITS? One of them is for 'Control', what is the other CTR 
> > for?
> 
> Actually, with CTR being "counter", I'd like the naming to stay that
> way: These are "fixed control bits" bit "control bits of a fixed
> counter".

Yes Jan, Fixed-Function Performance Counter Control Bits (from the MSR name).
Thanks.

Dietmar.

-- 
Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel