[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] ocaml bindings

On 05/04/13 20:05, Anil Madhavapeddy wrote:
> On 5 Apr 2013, at 11:19, Vincent Bernardoff <vb@xxxxxxxxxxxxxx> wrote:
>> Hi there.
>> Please try applying this patch (and only this patch) on top of Xen (4.2 or 
>> unstable).
>> It should fix all the OCaml issues.
>> Please give me feedback if possible.
> --- a/tools/ocaml/common.make
> +++ b/tools/ocaml/common.make
> @@ -15,7 +15,7 @@ OCAMLOPTFLAG_G := $(shell $(OCAMLOPT) -h 2>&1 | sed -n 's/^ 
>  *\(-g\) .*/\1/p')
> $(OCAMLINCLUDE) -cc $(CC) -w F -warn-error F
>  OCAMLCFLAGS += -g $(OCAMLINCLUDE) -w F -warn-error F
> -VERSION := 4.1
> +VERSION := 4.3
> This shouldn't really be hardcoded here; isn't there XEN_VERSION or something 
> from the main Makefile's that'll stop this getting out of sync all the time?
> -anil

There are several places like this in the build system.  The docs
directory is another location which comes to mind.

XEN_VERSION is defined in the Xen root makefile, and there is a .PHONY
target called xenversion to get at it.

I did submit a patch ages ago but it got nowhere (and now I cant seem to
find the email in the archives)  I will see if I still have the patch
lying around


> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.