[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Qemu-devel] [PATCHv2 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect


--On 5 April 2013 15:22:16 +0100 Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> wrote:

@@ -756,6 +753,41 @@ static int blk_init(struct XenDevice *xendev)
         info  |= VDISK_CDROM;

+    blkdev->file_blk  = BLOCK_SIZE;

This is useless, you are setting file_blk twice. Just remove this please.

Actually the problem was I failed to remove it from blk_connect on the
qemu-upstream-unstable patch set. The qemu-upstream-4.2 patch set is fine.

I've thus resent, with it still in blk_init, but removed from blk_connect.

Alex Bligh

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.