Re: [Xen-devel] [PATCH] x86/mm/shadow: spurious warning when unmapping xenheap pages.

[Tim Deegan <tim@xxxxxxx>]

At 09:37 +0100 on 05 Apr (1365154638), Jan Beulich wrote:
> >>> On 05.04.13 at 10:30, Tim Deegan <tim@xxxxxxx> wrote:
> > At 09:11 +0100 on 05 Apr (1365153095), Jan Beulich wrote:
> >> >>> On 28.03.13 at 11:35, Tim Deegan <tim@xxxxxxx> wrote:
> >> > Xenheap pages will always have an extra typecount, taken in
> >> > share_xen_page_with_guest(), which doesn't come from a shadow PTE.
> >> > Adjust the warning in sh_remove_all_mappings() to account for it.
> >> > 
> >> > Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> > Signed-off-by: Tim Deegan <tim@xxxxxxx>
> >> 
> >> I suppose this ought to go into 4.2.2 and 4.1.5 as well?
> > 
> > Could do -- it's just suppressing a printk, so not a particularly urgent
> > fix AFAICT.
> 
> But the message, if present when inspecting some random log,
> looks worrying, so getting rid of the false positive is likely going
> to help assessing the health of systems/guests.

Sure.  In any case the patch is harmless, so there should be no risk to
putting it in.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel