Re: [Xen-devel] [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Thu, 4 Apr 2013 10:12:19 +0100
Tim Deegan <tim@xxxxxxx> wrote:

> At 18:37 -0700 on 02 Apr (1364927854), Mukesh Rathor wrote:
> > On Thu, 21 Mar 2013 16:49:12 +0000 Tim Deegan <tim@xxxxxxx> wrote:
> > > > +static int vmxit_invlpg(void)
> > > > +{
> > > > +    ulong vaddr = __vmread(EXIT_QUALIFICATION);
> > > > +
> > > > +    vmx_update_guest_eip();
> > > > +    vpid_sync_vcpu_gva(current, vaddr);
> > > 
> > > If there's no special handling of invlpg, you should just not
> > > intercept it. 
> > 
> > well, we call vpid_sync_vcpu_gva(), but we can optimize this further
> > in future.
> 
> It would be trivial just to drop the intercept now.  All
> vpid_sync_vcpu_gva() does is emulate (potentially rather
> inefficiently) the invlpg that's been intercepted.

Ok, got it now. Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel