[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/xen: populate boot_params with EDD data

On 03/04/13 13:47, Jan Beulich wrote:
>>>> On 03.04.13 at 13:10, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
>> +}
>> +#else
>> +static inline void __init load_edd(void)
>> +{
>> +}
>> +#endif
> And if you put the conditionals inside the curly braces, you can
> avoid the else portion here altogether.

I thought the #if around the whole function was the standard pattern.
Konrad, what's your opinion here?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.