Re: [Xen-devel] [PATCH 1/4] IOMMU: allow MSI message to IRTE propagation to fail

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Tue, Mar 26, 2013 at 9:03 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

> --- a/xen/drivers/passthrough/amd/iommu_intr.c
> +++ b/xen/drivers/passthrough/amd/iommu_intr.c
> @@ -359,16 +359,13 @@ done:
>      }
>  }
>
> -void amd_iommu_msi_msg_update_ire(
> +int amd_iommu_msi_msg_update_ire(
>      struct msi_desc *msi_desc, struct msi_msg *msg)
>  {
>      struct pci_dev *pdev = msi_desc->dev;
>      int bdf, seg;
>      struct amd_iommu *iommu;
>
> -    if ( !iommu_intremap )
> -        return;
> -

It's not clear to me from the description -- why are we removing this?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel