Re: [Xen-devel] [PATCH 17/18 V2]: PVH xen: PVH dom0 creation...

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Mon, 18 Mar 2013 16:06:02 -0400
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:

> On Fri, Mar 15, 2013 at 06:06:45PM -0700, Mukesh Rathor wrote:
> > +static __init void copy_pvh(char *dest, char *src, int bytes)
> > +{
> > +    /* raw_copy_to_guest() -> copy_to_user_hvm -> __hvm_copy needs
> > curr 
> > +     * to point to the hvm/pvh vcpu. Hence for PVH dom0 we can't
> > use that.
> > +     * So we just use dbg_rw_mem().
> > +     */
> > +    int rem = dbg_rw_mem((dbgva_t)dest, (unsigned char *)src,
> > bytes, 0, 1, 0);
> > +    if (rem) {
> > +        printk("PVH: Failed to copy to dom0. len:%d rem:%d\n",
> > bytes, rem);
> > +        BUG();
> 
> Wait a minute? This is debug code but you use for copying?! Why not
> __copy_to_user?

No, it's not debug code, I wrote the function to work for all
guests under all conditions, but it was only for debugger, so called
it dbg_*.  

Looking at alternatives.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel