Re: [Xen-devel] [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c

[Tim Deegan <tim@xxxxxxx>]

At 08:32 +0000 on 22 Mar (1363941127), Jan Beulich wrote:
> >>> On 21.03.13 at 17:49, Tim Deegan <tim@xxxxxxx> wrote:
> >> +            else if (cr == 3) {
> >> +                printk("PVH: d%d: unexpected cr3 access vmexit. 
> >> rip:%lx\n", 
> > 
> >> +                       current->domain->domain_id, regs->rip);
> >> +                domain_crash_synchronous();
> > 
> > Again, ITYM BUG().  And again. probably a switch statement.
> 
> Actually, in cases where just crashing the guest is safe (i.e. no
> other execution state is corrupted), I think avoiding the use of
> BUG() is quite desirable. I wouldn't mind an ASSERT() though, to
> catch developers' attention.

Ack, ASSERT() + crash is better. 

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel