Re: [Xen-devel] [RFC PATCH V5 04/15] evtchn: generalize event channel operations

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.03.13 at 16:15, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> @@ -1180,6 +1142,13 @@ void notify_via_xen_event_channel(struct domain *ld, 
> int lport)
>      spin_unlock(&ld->event_lock);
>  }
>  
> +const static struct evtchn_port_ops evtchn_2l_ops = {

Even if the language permits this, "const" preceding "static" looks
a bit odd (and is inconsistent with all other code, with one
exception in the arinc653 scheduler).

Jan

> +    .is_pending    = evtchn_bitmap_is_pending,
> +    .is_masked     = evtchn_bitmap_is_masked,
> +    .set_pending   = evtchn_bitmap_set_pending,
> +    .unmask        = evtchn_bitmap_unmask,
> +    .clear_pending = evtchn_bitmap_clear_pending
> +};
>  
>  int evtchn_init(struct domain *d)
>  {



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel