Re: [Xen-devel] [PATCH 1/18 V2]: PVH xen: turn gdb_frames/gdt_ents into union

[George Dunlap <dunlapg@xxxxxxxxx>]

On Mon, Mar 18, 2013 at 11:54 PM, Mukesh Rathor
<mukesh.rathor@xxxxxxxxxx> wrote:
> On Sat, 16 Mar 2013 09:46:00 -0400
> Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> wrote:
>
>> On Fri, Mar 15, 2013 at 05:14:50PM -0700, Mukesh Rathor wrote:
>> > PVH only needs gdtaddr and gdtsz, so a union is created. There is no
>> > functional code change in this patch.
>>
>> Did you copy-n-paste this patch in? It is all malformed.
>>
>> git send-email works great for the patches. You can just do:
>>
>> git format-patch 6524455339349779c553af949b81d3d46f051797..
>> [generates the patches]
>>
>> git send-email --to xen-devel@xxxxxxxxxxxxx --to <other people> \
>>   --annotate --compose --subject "[PATCH v2] PVH patches." *.patch
>>
>> and in your .gitconfig have:
>>
>> [sendemail]
>>     smtpserver = stbeehive.oracle.com
>>     smtpserverport = 465
>>     smtpencryption = tls
>
>
> Gives me "Unable to initialize SMTP properly. " error.
>
> But changing tls to ssl works.
>
> Ok, will use git email next version of patches.

Actually, could you re-post this series as-is, so more reviewers can
look at the code in-situ without having to manually adjust damaged
patches?  I think if you make the subject prefix "PATCH v2 RESEND" it
should be clear what's going on.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel