Re: [Xen-devel] [PATCH 16/18 V2]: PVH xen: elf changes to pref for dom0 PVH.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.03.13 at 02:04, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> +    /* raw_copy_to_guest -> copy_to_user_hvm -> __hvm_copy needs curr to
> +     * point to the hvm/pvh vcpu. Hence for PVH dom0 we can't use that. For 
> now
> +     * just use dbg_rw_mem(). */

Again - definitely not outside of an RFC patch.

> +    if ( is_pvh_dom0 ) 
> +    {
> +        int j, rem; 
> +        rem = dbg_rw_mem((dbgva_t)dst, (dbgbyte_t *)src, (int)filesz, 0, 1, 
> 0);
> +        if ( rem ) {
> +            printk("Failed to copy elf binary. len:%ld rem:%d\n", filesz, 
> rem);
> +            return -1;
> +        }
> +        for (j=0; j < memsz - filesz; j++) {
> +            unsigned char zero=0;
> +            rem = dbg_rw_mem((dbgva_t)(dst+filesz+j), &zero, 1, 0, 1, 0);
> +            if (rem) {
> +                printk("Failed to copy to:%p rem:%d\n", dst+filesz+j, rem);
> +                return -1;
> +            }
> +        }
> +        return 0;
> +    }

And with that I put under question the rest of the changes don in
this patch.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel