Re: [Xen-devel] [Xen-staging] [xen staging] libxl: use qemu-xen (upstream QEMU) as device model by default

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [Xen-staging] [xen staging] libxl: use 
qemu-xen (upstream QEMU) as device model by default"):
> >      if (!b_info->device_model_version) {
> > -        if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
> > -            b_info->device_model_version =
> > -                LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL;
> > +        if (b_info->type == LIBXL_DOMAIN_TYPE_HVM)
> > +            if (libxl_defbool_val(info->device_model_stubdomain)) {
> 
> This broke the build.

Sorry about that.  I must not even have build-tested this "final"
version :-/.

> libxl_create.c: In function âlibxl__domain_build_info_setdefaultâ:
> libxl_create.c:109: error: âinfoâ undeclared (first use in this function)
> libxl_create.c:109: error: (Each undeclared identifier is reported only once
> libxl_create.c:109: error: for each function it appears in.)
> cc1: warnings being treated as errors
> libxl_create.c:108: error: suggest explicit braces to avoid ambiguous âelseâ
> libxl_create.c: At top level:
> libxl_create.c:141: error: expected identifier or â(â before âifâ
> ...
> 
> Fix is to insert the missing opening brace and s/info/b_info/ in one spot.

Applied, thanks.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel