Re: [Xen-devel] [PATCH v1 12/12] hotplug/Linux: add iscsi block hotplug script

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[Xen-devel] [PATCH v1 12/12] hotplug/Linux: add iscsi 
block hotplug script"):
> This hotplug script has been tested with IET and NetBSD iSCSI targets,
> without authentication.
> 
> Authentication parameters, including the password are passed as
> parameters to iscsiadm, which is not recommended because other users
> of the system can see them. This parameters could also be set by
> editing a corresponding file directly, but the location of this file
> seems to be different depending on the distribution used.

Would it be possible for the user to specify the file that the
password should be read from ?

Did you write this script from scratch ?  (TBH I don't intend to
review it in detail...)

Why no set -e ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel