Re: [Xen-devel] [PATCH v1 06/12] libxl: add support for different hotplug interfaces

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[Xen-devel] [PATCH v1 06/12] libxl: add support for 
different hotplug interfaces"):
> Add a new variable to libxl_device_disk "hotplug_version", that will
> be automatically set to the detected hotplug script interface version.
...
> +    /*
> +     * We might have devices that have been prepared, but with no
> +     * frontend xenstore entries, so domain destruction fails to
> +     * find them, that is why we have to unprepare them manually.
> +     */
> +    libxl__multidev_begin(ao, &dcs->multidev);
> +    dcs->multidev.callback = domcreate_unprepare_cb;
> +    libxl__unprepare_disks(egc, ao, domid, d_config, &dcs->multidev);
> +    libxl__multidev_prepared(egc, &dcs->multidev, 0);
> +    return;

I don't think this is correct.  What if the calling application
crashes and this code is never executed ?  Then libxl_destroy would
leak this state.

So I think you need to record the preparedness somewhere where
libxl_destroy can find it.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel