Re: [Xen-devel] [PATCH] ACPI: Add fixups for AMD P-state figures.

[Borislav Petkov <bp@xxxxxxx>]

On Wed, Mar 06, 2013 at 09:05:57AM +0000, Jan Beulich wrote:
> > +        if (boot_cpu_data.x86 == 0x10)
> > +            px->core_frequency = (100 * (fid + 0x10)) >> did;
> > +        else
> > +            px->core_frequency = (100 * (fid + 8)) >> did;
> 
> 0x10 vs 8? Please settle on decimal (preferred) or hex numbers in
> a calculation like this.

This is directly copied from upstream. Don't ask me why it was done like
that. :-)

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel