Re: [Xen-devel] linux-3.9-rc1: WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x88/0xa0() Device pciback disabling already-disabled device

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Mar 04, 2013 at 11:43:23PM +0100, Sander Eikelenboom wrote:
> Hi Konrad,
> 
> While shuting down a HVM guest with pci devices passed through i get this one 
> below ...
> Both dom0 and domU run the same linux-3.9-rc1 (+ Thomas Gleixner patches)

OK, that one looks pretty easy to fix:
> [  759.027692] Hardware name: MS-7640
> [  759.034233] Device pciback
> [  759.034233] disabling already-disabled device
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Could you try the below patch please?

diff --git a/drivers/xen/xen-pciback/pciback_ops.c 
b/drivers/xen/xen-pciback/pciback_ops.c
index 37c1f82..b98cf0c 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -113,7 +113,8 @@ void xen_pcibk_reset_device(struct pci_dev *dev)
                if (dev->msi_enabled)
                        pci_disable_msi(dev);
 #endif
-               pci_disable_device(dev);
+               if (pci_is_enabled(dev))
+                       pci_disable_device(dev);
 
                pci_write_config_word(dev, PCI_COMMAND, 0);
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel