[Xen-devel] suspicious shift in compat_memory_op()

[Xi Wang <xi@xxxxxxx>]

xen/common/compat/memory.c:175

  if ( order_delta >= 0 )
      nat.xchg->out.nr_extents = end_extent >> order_delta;
  else
      nat.xchg->out.nr_extents = end_extent << order_delta;

Shifting a negative "order_delta" doesn't make much sense.

Should it be something like "end_extent << -order_delta"?  Thanks.

- xi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel