Re: [Xen-devel] [PATCH v2] tools: Improve make deb

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-02-26 at 13:12 +0000, Stefano Stabellini wrote:
> On Tue, 26 Feb 2013, Ian Campbell wrote:
> > On Tue, 2013-02-26 at 12:58 +0000, Stefano Stabellini wrote:
> > > > +cat >deb/DEBIAN/postrm <<EOF
> > > > +#!/bin/bash -e
> > > > +insserv -r xendomains &&
> > > > +insserv -r xencommons
> > [...]
> > > All the changes look good to me
> > 
> > This one certainly isn't, calling insserv directly in a pre/post inst is
> > not the correct Debian interface to use.
> > 
> > Better to call update-rc.d I think, or use dh_installinit (and grow a
> > build time dependency on debhelper).
> 
> I am _very_ ignorant in deb packaging, but this wiki
> [...]
>  maybe this is the recommended thing to do for sysadmins, not for
> packagers?

AIUI, yes. The document to refer to for anything to do with Debian
Packaging is the Debian Policy Manual: 
        http://www.debian.org/doc/debian-policy/

In this case: 
        http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.3.3
        
        Maintainers should use the abstraction layer provided by the
        update-rc.d and invoke-rc.d programs to deal with initscripts in
        their packages' scripts such as postinst, prerm and postrm.
        
        Directly managing the /etc/rc?.d links and directly invoking
        the /etc/init.d/ initscripts should be done only by packages
        providing the initscript subsystem (such as sysv-rc and
        file-rc). 

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel